flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2026-01-09 20:01:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

some cleanup...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2013-12-26 03:59:36 +04:00
parent b2259e221b
commit 90315ebc57
1 changed files with 28 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
ui/TODO.otl
View File

@ -111,34 +111,6 @@ Roadmap
[_] 32% Gen 3 current todo [_] 32% Gen 3 current todo
[_] 64% High priority [_] 64% High priority
[_] ASAP: Need visual indicators for long operations... [_] ASAP: Need visual indicators for long operations...
[X] BUG: shifting around images in very short ribbons produces lots of errors
| Procedure:
| - crop a ribbon of two-three images
| - start shifting
|
| Problems:
| - wrong alignment
| - sometimes by shifting an image up the focus shifts to the
| upper ribbon
|
| The direct cause of the problem:
| - errors:
| - SyntaxError - likely the JSON parser in getImageGID()
| - TypeError - property of null
|
| Likely causes:
| - we access images BEFORE they are initialized properly...
|
| Solution strategy:
| - make aligning independent of DOM state where possible...
| - make parts of the code wait for updates to finish...
|
|
| Actual case:
| - this was not a problem with race conditions...
| - essentially all this took is a careful look at event and
| action ordering, and a forgotten filter...
| (filtering for images is a possible bug class)
[_] 66% Bookmarks [_] 66% Bookmarks
[X] toggle [X] toggle
[X] save/load [X] save/load
@ -555,6 +527,34 @@ Roadmap
| Actual: | Actual:
| drops to last placeholder | drops to last placeholder
| |
[X] BUG: shifting around images in very short ribbons produces lots of errors
| Procedure:
| - crop a ribbon of two-three images
| - start shifting
|
| Problems:
| - wrong alignment
| - sometimes by shifting an image up the focus shifts to the
| upper ribbon
|
| The direct cause of the problem:
| - errors:
| - SyntaxError - likely the JSON parser in getImageGID()
| - TypeError - property of null
|
| Likely causes:
| - we access images BEFORE they are initialized properly...
|
| Solution strategy:
| - make aligning independent of DOM state where possible...
| - make parts of the code wait for updates to finish...
|
|
| Actual case:
| - this was not a problem with race conditions...
| - essentially all this took is a careful look at event and
| action ordering, and a forgotten filter...
| (filtering for images is a possible bug class)
[X] BUG: appear to be leaking memory on very large sets of images (>8K) [X] BUG: appear to be leaking memory on very large sets of images (>8K)
| don't remember it before, so it might be due to the new | don't remember it before, so it might be due to the new
| loadImagesAround(..) | loadImagesAround(..)